Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added subscription limits check #370

Merged
merged 1 commit into from
Jun 27, 2023
Merged

chore: added subscription limits check #370

merged 1 commit into from
Jun 27, 2023

Conversation

mtsitrin
Copy link
Contributor

PR Standards

Opening a pull request should be able to meet the following requirements

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@mtsitrin mtsitrin requested a review from a team as a code owner June 25, 2023 10:28
@mtsitrin mtsitrin linked an issue Jun 25, 2023 that may be closed by this pull request
Add max subscription clients check in the subscribe rpc method #287
Closed
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Merging #370 (3834612) into main (5abf3ca) will decrease coverage by 4.24%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
- Coverage   55.39%   51.15%   -4.24%     
==========================================
  Files          86       89       +3     
  Lines       13234    14203     +969     
==========================================
- Hits         7331     7266      -65     
- Misses       4879     5933    +1054     
+ Partials     1024     1004      -20
Impacted Files Coverage Δ
rpc/json/service.go 64.53% <0.00%> (-1.55%) ⬇️
rpc/client/client.go 51.62% <22.22%> (-0.09%) ⬇️

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mtsitrin mtsitrin requested a review from omritoptix June 26, 2023 08:03
@mtsitrin mtsitrin merged commit 216740a into main Jun 27, 2023
@mtsitrin mtsitrin deleted the mtsitrin/287-add-max-subscription-clients-check-in-the-subscribe-rpc-method branch June 27, 2023 06:28
@omritoptix omritoptix mentioned this pull request Jul 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omritoptix omritoptix omritoptix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add max subscription clients check in the subscribe rpc method
2 participants
@mtsitrin @omritoptix